backlog: DRAFT-14 — per-group transformer fitting - #13
Closed
ahrzb wants to merge 1 commit into
Closed
Conversation
…al, Wren's measurements)
Owner
Author
|
Superseded by #14, the rolling board PR — same DRAFT-14 commit, now on the standing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board-only change (
backlog/**). One new draft, no code.DRAFT-14 —
transformer(x) OVER (PARTITION BY g)fits one transformer per groupAmirHossein's proposal, routed via Wren out of TASK-3 brainstorming. Wren's measurements are what make it scopeable, so they're recorded verbatim in the ticket.
The reframe that matters: today a transformer ref is fitted once globally — measured, with
country a={10,20}, b={30,50}the state holdsavg_age=[27.5], not per-country 15/40. That is the correct semantic (it matches sklearn, where a Pipeline step fits once on all training data), so this is a new feature, not a bug.The split, which is the spine of the ticket:
PARTITION BYform yields one state row per group,batch == infer, and unseen groups return NULL for free via the existing unseen-partition semantic.Four open questions, why it's a draft not a task:
OVER (g)shorthand vs standardOVER (PARTITION BY g). Wren leans standard; (a) then desugars into already-valid SQL, whereas a shorthand buys new parsing for no new capability.Explicitly flagged as distinct from DRAFT-11: that one is about how arguments bind; this is about what data a transformer is fitted on.
🤖 Generated with Claude Code